Hi Frank, On Thu, 2025-02-27 at 18:47 -0500, Frank Ch. Eigler wrote: > > We should make dwarf_getsrcfiles and dwarf_getsrclines independent so > > callers that onle need the file table don't need to "pay" for parsing > > the whole line table. (I thought we had a bug for that, but cannot > > find it now. If you also cannot find it, please let me know and I'll > > file a new one.) > > I believe you're referring to PR27405, which amerey himself implemented > in commit d4b0848be.
Thanks! Indeed. My memory is clearly failing. Good this is already fixed. But now we don't have an easy excuse to revisit the locking :) > > [...] So you are serializing the file/line table parsing. > > (On the other hand, at this stage of concurrency management in > elfutils, it may make perfect sense to err on the side of > *correctness* now, and only complicating locking later when > serious contention hits to performance are indicated.) Sure. But I think the current locking proposal, using an indirect lock from a "parent" object, feels like it is harder to proof correct than having the lock in the object itself. Cheers, Mark
