Hi Aaron, On Thu, Jan 30, 2025 at 09:35:50PM -0500, Aaron Merey wrote: > `valgrind --track-fds=yes` will report errors for file descriptor leaks > and attempts at closing invalid file descriptors.
This looks good to me, but could we apply the patches in "reverse" order so we don't get test failures in between the patches? Would help when bisecting. And not getting the buildbots yelling at us. Cheers, Mark P.S. Sasha gave a really nice presentation on valgrind --track-fds at Fosdem this weekend: https://fosdem.org/2025/schedule/event/fosdem-2025-4178-using-the-valgrind-error-manager-for-file-descriptor-tracking/ > Signed-off-by: Aaron Merey <ame...@redhat.com> > --- > tests/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 8f087798..625a014f 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -692,7 +692,7 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh run-ar.sh \ > > > if USE_VALGRIND > -valgrind_cmd=valgrind -q --leak-check=full --error-exitcode=1 > +valgrind_cmd=valgrind -q --leak-check=full --error-exitcode=1 --track-fds=yes > endif
