Hi, On Mon, Jan 27, 2025 at 05:23:15AM +0000, parona wrote: > Background for this patch is https://bugs.gentoo.org/948878 where > are user had installed a standalone error implementation for a > different package leading to a build failure.
There is also some discussion in this elfutils bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32548 My main question/confusion is where the error.h include comes from. elfutils does support libcs like musl who don't provide error.h but do provide err.h. Then the build should provide its own error function through lib/system.h. So maybe our configure check is wrong and it should just test whether there is an error.h but also if you can link the result? > Decided to automagically link to it instead of forcing it as a > dependency as its only packaged on Gentoo. > > https://hacktivis.me/git/error-standalone/ > https://repology.org/project/error-standalone/versions > > Followed the approach that was used for argp and fts to my best ability. I think that should work. But it would be slightly nicer if we only had to change the configure test (and maybe the include guards) so that the error from lib/system.h is used. But I might misunderstand the situation and such configure magic is too magic :) Cheers, Mark
