Hi Aaron, On Thu, Jan 23, 2025 at 09:15:10PM -0500, Aaron Merey wrote: > > On Sun, Jan 19, 2025 at 10:20:30PM -0500, Aaron Merey wrote: > > > res = __libdw_getsrcfiles (cu->dbg, debug_line_offset, > > > __libdw_getcompdir (cudie), > > > > So is the lock to protect all paths through __libdw_getsrcfiles? > > This patch series contains enough locking to get the testsuite (in > particular the new eu-search tests) passing. There is another path > into __libdw_getsrcfiles in dwarf_macro_getsrcfiles that does not have > any locking at the moment.
It might make reviewing a little easier if the locks for the same field/function were in the same patch. Or if the patches referred to each other. Then it is easier to see why the locking is correct/complete. Thanks, Mark
