On Mon, Nov 18, 2024 at 1:12 PM Mark Wielaard <m...@klomp.org> wrote:
>
> Since b2f225d6bff8 ("Consolidate and add files to clean target variables")
> autoreconf (automake) produces these warnings:
>
> debuginfod/Makefile.am:130: warning: CLEANFILES multiply defined in condition
> TRUE ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> debuginfod/Makefile.am:32: 'config/eu.am' included from here
> libasm/Makefile.am:91: warning: CLEANFILES multiply defined in condition TRUE
> ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> libasm/Makefile.am:30: 'config/eu.am' included from here
> libcpu/Makefile.am:105: warning: CLEANFILES multiply defined in condition
> TRUE ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> libcpu/Makefile.am:30: 'config/eu.am' included from here
> libdw/Makefile.am:156: warning: CLEANFILES multiply defined in condition TRUE
> ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> libdw/Makefile.am:30: 'config/eu.am' included from here
> libelf/Makefile.am:142: warning: CLEANFILES multiply defined in condition
> TRUE ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> libelf/Makefile.am:30: 'config/eu.am' included from here
> src/Makefile.am:47: warning: CLEANFILES multiply defined in condition TRUE ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> src/Makefile.am:19: 'config/eu.am' included from here
> tests/Makefile.am:891: warning: CLEANFILES multiply defined in condition TRUE
> ...
> config/eu.am:138: ... 'CLEANFILES' previously defined here
> tests/Makefile.am:19: 'config/eu.am' included from here
>
> This is because config/eu.am defines a default CLEANFILES. So those
> Makefile.am files should add to CLEANFILES with += instead of
> redefining CLEANFILES with =.
>
> * debuginfod/Makefile.am (CLEANFILES): Use +=.
> * libasm/Makefile.am (CLEANFILES): Likewise.
> * libcpu/Makefile.am (CLEANFILES): Likewise.
> * libdw/Makefile.am (CLEANFILES): Likewise.
> * libelf/Makefile.am (CLEANFILES): Likewise.
> * src/Makefile.am (CLEANFILES): Likewise.
> * tests/Makefile.am (CLEANFILES): Likewise.
Thanks Mark, this patch fixes the warnings for me.
Aaron
