On Thu, Oct 17, 2024 at 11:50 AM Serhei Makarov <ser...@serhei.io> wrote:
>
> > I'm comfortable with this being merged for the release as long as any
> > build errors are sorted out and we emphasize in the usage text and
> > NEWS that eu-stacktrace is an experimental feature with a possibly
> > unstable ABI.
> I think the key point is that for now eu-stacktrace has to be explicitly
> enabled in the configury. If the user doesn't ask for it, it won't be built.
> We'll revisit the status of the feature when there's a released Sysprof
> version with the stack sampling included.
I'm seeing eu-stacktrace built by default on x86 with no
--enable-stacktrace given to configure.
$ ./configure
[...]
eu-stacktrace support : yes
> Would the following wording for NEWS work?
>
> stacktrace: Experimental new tool that can process a stream of stack
> samples from the Sysprof profiler and unwind them into call
> chains. Enable on x86 with --enable-stacktrace. Requires a
> matching set of patches for Sysprof (available at
>
> https://git.sr.ht/~serhei/sysprof-experiments/log/serhei/samples-via-fifo).
LGTM. Can we change the eu-stacktrace usage text to mention that this
is an experimental tool? And can "see README.eu-stacktrace in the
source branch." include the URL?
Thanks,
Aaron
