On Wed, Mar 27, 2024 at 10:06 AM Mark Wielaard <m...@klomp.org> wrote:
>
> Not knowing fish this looks OK to me. We might want a testcase like
> the one that was just added for config/profile.sh to make sure we ship
> something that runs correctly. Could be something as simple as:
>
> type fish 2>/dev/null || (echo "no fish installed"; exit 77)
> fish ${abs_top_builddir}/config/profile.fish
On Sat, Mar 30, 2024 at 7:32 AM Frederik “Freso” S. Olesen
<freso...@gmail.com> wrote:
>
> On Wed, Mar 27, 2024 at 03:06:48PM +0100, Mark Wielaard wrote:
> > Adding Freso to the CC since he is the original author of the fish
> > support.
>
> Looks good to me! I don’t want to claim any specific authorship
> or special knowledge of it. I basically just adapted the existing
> bash/.sh profile script for local use and then retrofitted that
> for upstream submission. I’m happy that other fish users are
> contributing to improving it! :)
Thanks, pushed as commit eeea53b41b12dc9633ce6a3b1eb5c7d0ba0e057f
with Mark's testcase added.
Aaron
