Hi Martin, On Sat, Mar 02, 2024 at 07:43:38PM -0300, Martin Rodriguez Reboredo wrote: > On 3/2/24 17:47, Mark Wielaard wrote: > >On Fri, Mar 01, 2024 at 05:04:05PM -0300, Martin Rodriguez Reboredo wrote: > >>Added a new function dwfl_set_offline_next_addres which will set said > >>field from the Dwfl struct. This is a requirement for listing functions > >>from their addresses when using libdwfl offline, otherwise wrong symbols > >>are going to be returned. > > > >Could you give an example or testcase for this? > > This is intended for the Linux kernel perf tool so you might see it in > action when I publish the changes. In regards to testing I thought that > it was not needed due to the patch being a simple setter, but as > requested I can think something in the lines of.
It would be interesting to see the perf tool patch. I don't understand the use case. So I assume perf currently does something which is wrong and with your patch calling this new dwfl_set_offline_next_addres it will do the right thing. That is what I was thinking of when asking for an example or testcase. I agree that on itself such a simple setter doesn't need a dedicated testcase. But maybe we can come up with a testcase given the right context. Cheers, Mark
