Hi Mark, 在 2024/2/10 08:20, Mark Wielaard 写道: > Hi Ying, > > Sorry I keep postponing this. I don't have access to a mips64le box, > the cfarm only has 64bit big endian mips machines. But the part I am > struggling with is the relocation data conversion needed in the > mips64le case. > > On Fri, Nov 03, 2023 at 01:18:12PM +0100, Mark Wielaard wrote: >> On Thu, 2023-11-02 at 14:55 +0800, Ying Huang wrote: >>> In mips64 little-endian, r_info consists of four byte fields(contains >>> three reloc types) and a 32-bit symbol index. In order to adapt >>> GELF_R_SYM and GELF_R_TYPE, need convert raw data to get correct symbol >>> index and type. >> This part and the new backends hooks look OK. > So to make progress could you split this part? Just a patch that adds > the initial mips backend (and the libebl and libelfP.h parts). And > another that introduces the libelf/elf_update and elf_getdata parts? OK, I would split it as you advised and submit patch v3. > Also could you take a look at CONTRIBUTING > https://sourceware.org/cgit/elfutils/tree/CONTRIBUTING > And provide a Signed-off-by line if you can/agree with that?
OK. > > Which MIPS variant(s) have you tested this against? Is it supposed to > only work for mips64le? Or also maps64[be] and/or mips32 bits? I had tested patch v2 on mips64el, mips32el/be, arm64, amd64, i386, and did not produce new fail tests. Only the part about 'the relocation data conversion' work for mips64el. Thanks, Ying
