Hi Mark, On Tue, Feb 6, 2024 at 10:36 AM Mark Wielaard <m...@klomp.org> wrote: > > So it looks like elfcmp explicitly checks ebl_section_strip_p and > doesn't compare sections that are strippable. Maybe we should add an > eu-elfcmp --all-sections flag? > > We should probably also check that it handles the new SHT_RELR sections > correctly. I see it only checks for SHT_REL and SHT_RELA in the code. > Although RELR is really simple and doesn't have symbol references. So > it is probably fine.
I added a PR for this: https://sourceware.org/bugzilla/show_bug.cgi?id=31345 > > adjust_all_relocs (Elf *elf, Elf_Scn *symtab, const GElf_Shdr *symshdr, > > - size_t map[], size_t map_size) > > + size_t map[], size_t map_size, bool *scn_filter) > > { > > Maybe bool scn_filter[] since it really is an array? Done. > Looks good in general. Just clean up in the new testcase and run it > with testrun. Done. Pushed as commit 2f9b180cc1. Aaron
