https://sourceware.org/bugzilla/show_bug.cgi?id=29696
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
Very nice find. How did you catch this btw?
Are there any tools that help find such a "double closes"?
If not maybe we can teach valgrind --track-fds=yes about it, which already can
track fd leaks, so it shouldn't be too hard to make it also detect double/bad
closes.
The patch seems obviously correct to me. Nice to now log close () failures,
which should help catch similar issues early.
Small nitpick. The "}else{" is a bit of a style break with the rest of the
code, which would say:
...
}
else
{
...
--
You are receiving this mail because:
You are on the CC list for the bug.
