Hi Aleksei, On Mon, 2023-02-13 at 20:10 +0000, Aleksei Vetrov via Elfutils-devel wrote: > __libdw_get_uleb128 and __libdw_get_sleb128 should check if addrp has > already reached the end before unrolling the first step. It is done by > moving __libdw_max_len to the beginning of the function, which can > notice, that addrp is beyond the end. Then we just check the result of > this function.
This looks good. And I couldn't measure any meaningful performance difference. Pushed. Even though this now catches all calls that have start >= end, I'll also push my other patch to add extra guards in the callers of get_(u|s)leb128, because that does provide us with better error messages. Thanks, Mark
