On Mittwoch, 13. Juli 2022 22:38:51 CEST Mark Wielaard wrote:
> Hi Milian,
>
> On Wed, Jul 13, 2022 at 09:36:45PM +0200, Milian Wolff wrote:
> > On Mittwoch, 13. Juli 2022 20:20:04 CEST Aaron Merey wrote:
> > > There weren't any concerns with the patch so I've gone ahead and merged
> > > it as commit a4b1839c3c46.
>
> Yeah, sorry, I should have spoken up on the list not just mumbled
> something on irc. My only concern was that I was afraid to pull in
> libdebuginfod.h api by default. But you handled to by making
> debuginfod_client handle an opaque pointer, which it of course is. So
> my worry was unfounded.
>
> But I did just now see it has a typo in libdw.map:
>
> ELFUTILS_0.187 {
> global:
> dwfl_get_debuginfod_client;
> } ELFUTILS_0.186;
>
> That should be ELFUTILS_0.188 we already released 0.187.Ah, thanks for spotting that. > Also (micro optimazition to prevent a PLT call) the internal calls > should use INTUSE (dwfl_get_debuginfod_client). TIL, thanks. I probably will never feel at home in C code bases with all these arcane macros :D > I made both changes and added a NEWS entry. See attached. LGTM. > > I got spammed by a flood of mails from buildbot, but from what I can tell > > the issues are all unrelated to my patch? Or did I break something? See > > e.g.: > > > > [1]: https://builder.sourceware.org/buildbot/#/builders/39/builds/41 > > Those are unrelated to your patch OK, thanks. -- Milian Wolff m...@milianw.de http://milianw.de
signature.asc
Description: This is a digitally signed message part.
