Hi Noah, On Mon, 2021-09-13 at 14:11 -0400, Noah Sanci via Elfutils-devel wrote: > Quick arithmetic change to the original patch with an updated commit > message.
Thanks for commenting this, it is easy to make an off-by-one (or two) error. > Previously, urls containing '/', so most urls, would escape '/' to %2F, > which is undesirable for use in other libraries which may escape > differently. This patch escapes the '/' and replaces all of them > ensuring there are no %2Fs sent. > Some inefficiencies within the code were fixed, such as changing constant > operations of a while loop within a for loop to a while loop outside of > a for loop. Also strlen is no longer used within the loop, simplifying > the interior operations to mere arithmetic. > > https://sourceware.org/bugzilla/show_bug.cgi?id=28034 Looks good. Could you push it to the master branch? (Please do rebase first, so we keep a linear history) Thanks, Mark
