Hi Frank, On Thu, 2021-04-29 at 12:13 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > This change was suggested by fedora fesco folks, to make it easier > for for auxiliary system daemons to use debuginfod by default. > > commit 4db2eba32aaed7d567f5ebea6b2eb7a6dc4b4b36 > Author: Frank Ch. Eigler <f...@redhat.com> > Date: Thu Apr 29 11:49:14 2021 -0400 > > PR27783 debuginfod: fetch default DEBUGINFOD_URLS from systemwide file > > Introduce use of a systemwide config file /etc/debuginfod_urls for a > fallback default for an unset $DEBUGINFOD_URLS. $DEBUGINFOD_URLS_FILE > overrides the default location of that file, which is probably mainly > useful for testing. Deprecate the similar /etc/profile.d/debuginfod* > mechanism that affected only login shells. > > OTOH, setting ANY of the following to be an empty string will disable > debuginfod-client capability: > - env var $DEBUGINFOD_URLS > - env var $DEBUGINFOD_URLS_FILE > - the file named by $DEBUGINFOD_URLS_FILE
So this replaces the profile environment settings with a system-wide config file. Which isn't really the same thing. Like you said it would also enable debuginfod in settings that don't have the DEBUGINFOD_URLS environment variable set, like system daemons. But I think that is the nice things about using the environment variable to indicate debuginfod-client should be used in a specific environment. If a daemon does want to use debuginfod-client it must set the environment variable explicitly. systemd provides a simple way to set environment variables, either through Environment or EnvironmentFile: http://0pointer.de/public/systemd-man/systemd.exec.html#Environment= Personally I think it would be better to make enablement of debuginfod- client specific for different environment (using it by default in a system daemon is different from running it standard in a login shell). Also some distros already seem to rely on the profile files, so removing them now seems like a bad idea. Cheers, Mark
