On Sun, Dec 20, 2020 at 06:37:36PM +0300, Dmitry V. Levin wrote:
> On Sun, Dec 20, 2020 at 04:28:30PM +0100, Mark Wielaard wrote:
> > Hi Dmitry,
> > 
> > On Sun, Dec 20, 2020 at 03:11:19PM +0300, Dmitry V. Levin wrote:
> > > Move subdirectory parts of the top level .gitignore into appropriate
> > > subdirectories.  This would be consistent with ChangeLog files,
> > > currently one has to update the top level ChangeLog file when the top
> > > level .gitignore file is changed in a way that affects specific
> > > subdirectories only.
> > 
> > Both changes look good to me. The only thing I would double check is
> > the /*.map entry in backends/.gitignore. It obviously comes from the
> > top-level .gitignore. But I don't know why it was there in the first
> > place.
> 
> There used to be libebl_*.map files, removed by commit
> 4f937e24dc7ad1820fc7c99a6dd6422657f14666.
> 
> I'll remove it from .gitignore in the second commit then.

Apparently, it's the only entry in backends/.gitignore, and it's really
not a good idea to have an empty backends/.gitignore file.

I could do it in the reverse order: the first commit would update
the top level .gitignore, and the second commit would split it.


-- 
ldv

Reply via email to