On Tue, Dec 15, 2020 at 09:52:40PM +0100, Mark Wielaard wrote: > Adding the symbol name associated with the symbol index number > makes the error messages a little bit more useful. We used to say: > > section [59] '.symtab': symbol 9: st_value out of bounds > > But now says: > > section [59] '.symtab': symbol 9 (.annobin_size.c.hot): st_value out of bounds
This is nice, thanks. I have one question about the patch: [...] > --- a/src/elflint.c > +++ b/src/elflint.c > @@ -706,7 +706,7 @@ section [%2d] '%s': XINDEX for zeroth entry not zero\n"), > continue; > } > > - const char *name = NULL; > + const char *name = "<invalid>"; This variable is used in some checks, for example, it's being passed to ebl_check_special_symbol. I'd like to make sure this change doesn't have any unintended consequences. -- ldv
