https://sourceware.org/bugzilla/show_bug.cgi?id=26321
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Giuliano Procida from comment #2)
> If my reading of this is right, some of check_constant_offset's callers have
> return values 0 success, -1 failure and others have count >= 0 success, -1
> failure.
>
> In which case, this makes sense.
yes, the failure case indicates that there was some bad DWARF data.
> I found the name of check_constant_offset particularly unhelpful.
I added the documentation and renamed the function to is_constant_offset.
Hopefully that name is slightly better.
commit 0c8cac246d18c7f9d161e68c951168750c72e26c (HEAD -> master)
Author: Mark Wielaard <[email protected]>
Date: Tue Aug 25 23:31:29 2020 +0200
libdw: Rename check_constant_offset to is_constant_offset.
The check_constant_offset code in dwarf_getlocation.c code is not very
intuitive, rename it to is_constant_offset and update the documentation.
https://sourceware.org/bugzilla/show_bug.cgi?id=26321
Signed-off-by: Mark Wielaard <[email protected]>
--
You are receiving this mail because:
You are on the CC list for the bug.
