Hi Aaron, On Thu, 2020-02-27 at 19:00 -0500, Aaron Merey wrote: > On Fri, Feb 21, 2020 at 3:09 PM Mark Wielaard <m...@klomp.org> wrote: > > But I think that means we should only create the cachedir (either > > $XDG_CACHE_HOME or $HOME/.cache). Which is what we are doing here. But > > I don't think we are expected to create all parents. I think it is > > reasonable to assume they already exist (it would almost always be > > $HOME anyway). > > > > Later in the code we create target_cache_path (the debuginfod_client > > subdir), again just as one directory (we made sure its parent exists). > > Makes sense, I stuck with this approach in the revised patch I've attached.
And it gets rid of the system call. Nice. > Also I ended up not attempting to rename a cache at the old default location. > IMO it brings negligible benefits while adding extra complexity plus the risk > of confusing users is greater than if we just leave the old cache where it is. Yes, make sense. Looks really good. Pushed to master. Thanks, Mark
