On Mon, Mar 17, 2014 at 2:46 AM, Fernando Luis Vázquez Cao
<[email protected]> wrote:
> On 02/18/2014 02:54 PM, Fernando Luis Vázquez Cao wrote:
>> Command line parameters QueuePairs, Node, EEE, DMAC and InterruptThrottleRate
>> do not exist these days. Remove all references to them in the Documentation
>> folder and update code comments.
>>
>> Signed-off-by: Fernando Luis Vazquez Cao <[email protected]>
>
> Ping?
>
> Is there any issue with the patch below? It is documenting
> driver features that are not longer present upstreaming,
> which was causing confusion among some of our customers.
>
Sorry I was out on sabbatical when this came in and it appears this
patch slipped through the cracks while I was out.
I have added your patch to my queue, thanks Fernando!
>
>> ---
>>
>> diff -urNp linux-3.14-rc3-orig/Documentation/networking/igb.txt
>> linux-3.14-rc3/Documentation/networking/igb.txt
>> --- linux-3.14-rc3-orig/Documentation/networking/igb.txt 2014-01-20
>> 11:40:07.000000000 +0900
>> +++ linux-3.14-rc3/Documentation/networking/igb.txt 2014-02-18
>> 14:08:40.789118556 +0900
>> @@ -36,54 +36,6 @@ Default Value: 0
>> This parameter adds support for SR-IOV. It causes the driver to spawn up
>> to
>> max_vfs worth of virtual function.
>>
>> -QueuePairs
>> -----------
>> -Valid Range: 0-1
>> -Default Value: 1 (TX and RX will be paired onto one interrupt vector)
>> -
>> -If set to 0, when MSI-X is enabled, the TX and RX will attempt to occupy
>> -separate vectors.
>> -
>> -This option can be overridden to 1 if there are not sufficient interrupts
>> -available. This can occur if any combination of RSS, VMDQ, and max_vfs
>> -results in more than 4 queues being used.
>> -
>> -Node
>> -----
>> -Valid Range: 0-n
>> -Default Value: -1 (off)
>> -
>> - 0 - n: where n is the number of the NUMA node that should be used to
>> - allocate memory for this adapter port.
>> - -1: uses the driver default of allocating memory on whichever processor is
>> - running insmod/modprobe.
>> -
>> - The Node parameter will allow you to pick which NUMA node you want to have
>> - the adapter allocate memory from. All driver structures, in-memory
>> queues,
>> - and receive buffers will be allocated on the node specified. This
>> parameter
>> - is only useful when interrupt affinity is specified, otherwise some
>> portion
>> - of the time the interrupt could run on a different core than the memory is
>> - allocated on, causing slower memory access and impacting throughput, CPU,
>> or
>> - both.
>> -
>> -EEE
>> ----
>> -Valid Range: 0-1
>> -Default Value: 1 (enabled)
>> -
>> - A link between two EEE-compliant devices will result in periodic bursts of
>> - data followed by long periods where in the link is in an idle state. This
>> Low
>> - Power Idle (LPI) state is supported in both 1Gbps and 100Mbps link speeds.
>> - NOTE: EEE support requires autonegotiation.
>> -
>> -DMAC
>> -----
>> -Valid Range: 0-1
>> -Default Value: 1 (enabled)
>> - Enables or disables DMA Coalescing feature.
>> -
>> -
>> -
>> Additional Configurations
>> =========================
>>
>> diff -urNp linux-3.14-rc3-orig/drivers/net/ethernet/intel/igb/igb_main.c
>> linux-3.14-rc3/drivers/net/ethernet/intel/igb/igb_main.c
>> --- linux-3.14-rc3-orig/drivers/net/ethernet/intel/igb/igb_main.c
>> 2014-02-18 13:52:13.626779905 +0900
>> +++ linux-3.14-rc3/drivers/net/ethernet/intel/igb/igb_main.c 2014-02-18
>> 14:19:59.160703492 +0900
>> @@ -4306,8 +4306,7 @@ enum latency_range {
>> * were determined based on theoretical maximum wire speed and testing
>> * data, in order to minimize response time while increasing bulk
>> * throughput.
>> - * This functionality is controlled by the InterruptThrottleRate module
>> - * parameter (see igb_param.c)
>> + * This functionality is controlled by ethtool's coalescing settings.
>> * NOTE: This function is called only when operating in a multiqueue
>> * receive environment.
>> **/
>> @@ -4381,8 +4380,7 @@ clear_counts:
>> * based on theoretical maximum wire speed and thresholds were set based
>> * on testing data as well as attempting to minimize response time
>> * while increasing bulk throughput.
>> - * this functionality is controlled by the InterruptThrottleRate module
>> - * parameter (see igb_param.c)
>> + * This functionality is controlled by ethtool's coalescing settings.
>> * NOTE: These calculations are only valid when operating in a single-
>> * queue environment.
>> **/
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
