On Sat, 2013-09-07 at 09:15 +0200, Daniel Borkmann wrote:
> Thanks for including SCTP! ;-)
:-)
> Here as well, I40E_ERR_NO_MEMORY vs -ENOMEM.
>
okay we will audit those and fix them.
>
> Nitpick: why s32 in the signature? There are a lot of such places, just int
> would have
> been fine probably.
>
agreed.
> }
> > + if (pf->lan_veb == I40E_NO_VEB) {
> > + v = i40e_veb_mem_alloc(pf);
> > + if (v < 0)
> > + break;
>
> Nitpick: I'd expect from *alloc() functions to return NULL, but fair enough.
I will take a look at what we can do about these.
> > + aq_buf = kzalloc(I40E_AQ_LARGE_BUF, GFP_KERNEL);
> > + if (!aq_buf)
> > + return -ENOMEM;
>
> More of such examples ... ;-) I40E_ERR_BAD_PTR vs. -ENOMEM on a s32 instead
> of int.
right
> > + } else if (pf->flags & I40E_FLAG_RSS_ENABLED &&
> > + !(pf->flags & I40E_FLAG_FDIR_ENABLED) &&
> > + !(pf->flags & I40E_FLAG_DCB_ENABLED)) {
> > +
> > + SET_RSS_SIZE;
>
> Can't these macros be done in a small inline function instead?
I'll take a look, as well for all instances of this.
Thanks again,
Jesse
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
