> -----Original Message----- > From: Stephen Hemminger [mailto:[email protected]] > Sent: Wednesday, June 19, 2013 11:38 AM > > On Thu, 13 Jun 2013 20:55:17 -0700 > Jeff Kirsher <[email protected]> wrote: > > > +static const struct i40e_stats i40e_gstrings_net_stats[] = { > > + I40E_NETDEV_STAT(rx_packets), > > + I40E_NETDEV_STAT(tx_packets), > > + I40E_NETDEV_STAT(rx_bytes), > > + I40E_NETDEV_STAT(tx_bytes), > > + I40E_NETDEV_STAT(rx_errors), > > + I40E_NETDEV_STAT(tx_errors), > > + I40E_NETDEV_STAT(rx_dropped), > > + I40E_NETDEV_STAT(tx_dropped), > > + I40E_NETDEV_STAT(multicast), > > + I40E_NETDEV_STAT(collisions), > > + I40E_NETDEV_STAT(rx_length_errors), > > + I40E_NETDEV_STAT(rx_over_errors), > > + I40E_NETDEV_STAT(rx_crc_errors), > > + I40E_NETDEV_STAT(rx_frame_errors), > > + I40E_NETDEV_STAT(rx_fifo_errors), > > + I40E_NETDEV_STAT(tx_aborted_errors), > > + I40E_NETDEV_STAT(tx_carrier_errors), > > + I40E_NETDEV_STAT(tx_fifo_errors), > > + I40E_NETDEV_STAT(tx_heartbeat_errors), > > + I40E_NETDEV_STAT(tx_window_errors), > > + I40E_NETDEV_STAT(rx_compressed), > > + I40E_NETDEV_STAT(tx_compressed), > > +} > > Why duplicate network device stats in ethtool stats?
Because the NETDEV_STATs are essentially a subset of the PF_STATs - see my answer to Ben for more details. We'll try to add a little more commentary here to make it more clear. sln ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
