https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1354498
** Description changed: - When using the XShape APIs*, windows that have a rectangular shape are - treated like normal windows (they get a title bar and shadow) even if - the rectangular region is much smaller than the window. + [ Impact ] - When a non-rectangular window changes its shape to be rectangular, it - gains a shadow that remains even after changing its shape back to be - non-rectangular. + Non-standard windows of a non-rectangular shape end up with rectangular + shadows drawn behind them by Unity. - Ideally there would always be a shadow that matches the shape of the - window. + It is better to have no shadow at all for these windows rather than an + incorrect rectangular shadow. - In the mean time, the correct behavior might be to remove the shadow - whenever a shape is applied. If the application wishes to remove an - applied shape, they could do something like: + [ Test Case ] - XShapeCombineMask(d, w, ShapeBounding, 0, 0, None, ShapeSet); + C code for a test case is attached to this bug. It needs to be compiled + and run to demonstrate the problem and solution. - Please let me know if you need any more details, or if I'm missing - something. (Unfortunately, the ubuntu-bug tool wouldn't work when filing - this bug). + [ Regression Potential ] - * http://www.x.org/releases/current/doc/xextproto/shape.html + Any code change to the Unity desktop shell could introduce a new crash + or hang. + + A possible regression in this particular fix is a lack of shadows when + expected, or a non-standard non-rectangular window still having a shadow + as before. + + [ Additional Info ] + + The Unity SRU fix for Ubuntu 14.04 LTS was cherry-picked from Ubuntu + 14.10 where it has been in production use for some time without + regression. ** Patch added: "debdiff between unity_7.2.3+14.04.20140826-0ubuntu1 and unity_7.2.4+14.04.20141217-0ubuntu1" https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1364225/+attachment/4293139/+files/unity_7.2.4%2B14.04.20141217-0ubuntu1.debdiff -- You received this bug notification because you are a member of DX Packages, which is subscribed to unity in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1364225 Title: Shadow applied inconsistently to windows that use XShape Status in Unity: Fix Committed Status in Unity 7.2 series: In Progress Status in unity package in Ubuntu: Fix Released Bug description: [ Impact ] Non-standard windows of a non-rectangular shape end up with rectangular shadows drawn behind them by Unity. It is better to have no shadow at all for these windows rather than an incorrect rectangular shadow. [ Test Case ] C code for a test case is attached to this bug. It needs to be compiled and run to demonstrate the problem and solution. [ Regression Potential ] Any code change to the Unity desktop shell could introduce a new crash or hang. A possible regression in this particular fix is a lack of shadows when expected, or a non-standard non-rectangular window still having a shadow as before. [ Additional Info ] The Unity SRU fix for Ubuntu 14.04 LTS was cherry-picked from Ubuntu 14.10 where it has been in production use for some time without regression. To manage notifications about this bug go to: https://bugs.launchpad.net/unity/+bug/1364225/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
