Ken, could you give your take on the below? i still feel duplicity should exit with an error code after the restore and mention the files it had problems with in the end. a warning i the middle might be easily overlooked by the user.
..ede On 23.01.2014 20:57, edgar.sol...@web.de wrote: > actually we issue a warning only.. > > to put it in other words. finishing without a special hint could give a user > the impression that all files were restored fine (on the command line) which > they weren't. we should circumvent that. > > ..ede > > On 23.01.2014 20:51, Michael Terry wrote: >> Interesting thought. We do issue a log message... And Deja Dup does >> collect those and warn user at end. I hadn't thought of duplicity doing >> that collating itself. >> >> I don't know how I feel about an error exit code. I'm not sold, but I don't >> feel strongly. Most error returns are currently for "could not finish" but >> we did sorta finish. Eh. >> >> It feels like brain surgery most of the time. :) >> >> -mt >> >> >> On 23 January 2014 14:43, <edgar.sol...@web.de <mailto:edgar.sol...@web.de>> >> wrote: >> >> On 23.01.2014 19:34, Michael Terry wrote: >> > There is a separate but related patch in 0.6.23 that makes the bug >> less severe by letting the user restore the rest of the files that aren't >> affected (rather than aborting restore entirely): >> > >> https://code.launchpad.net/~mterry/duplicity/catch-seq-copy-error/+merge/186106 >> >> <https://code.launchpad.net/%7Emterry/duplicity/catch-seq-copy-error/+merge/186106> >> >> <https://code.launchpad.net/%7Emterry/duplicity/catch-seq-copy-error/+merge/186106> >> >> i see.. well done. >> dangerous though! the error, it is an error if a file cannot be >> restored, should be collected and mentioned in the end with something like >> "some files could not be restored properly, check log". >> >> also we should end with an error exit code because of that of cause. >> >> ..ede >> >> PS: Mike, i admire your understanding of the whole duplicity >> infrastructure! looks like brain surgery to me most of the time... >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~duplicity-team >> <https://launchpad.net/%7Eduplicity-team> >> Post to : duplicity-team@lists.launchpad.net >> <mailto:duplicity-team@lists.launchpad.net> >> Unsubscribe : https://launchpad.net/~duplicity-team >> <https://launchpad.net/%7Eduplicity-team> >> More help : https://help.launchpad.net/ListHelp >> >> > > _______________________________________________ > Mailing list: https://launchpad.net/~duplicity-team > Post to : duplicity-team@lists.launchpad.net > Unsubscribe : https://launchpad.net/~duplicity-team > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~duplicity-team Post to : duplicity-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~duplicity-team More help : https://help.launchpad.net/ListHelp
