I've posted an updated webrev at: http://cr.opensolaris.org/~mgerdts/6750659-2008-11-16/
Changes since the previous (11-15) webrev include the following changes to the test case. - Move the test case into the usdt directory - Fix packaging for the test case in SUNWdtrt - Remove leading tab for "all" target in generated Makefile There have been no changes to the code in drti.c since the first code review request was sent. In the course of testing the test case, I ran across a problem with tst.resize1.d that prevents me from running the entire test suite. I am, however, able to run the new test. I believe that this is not related to the change I made, as I am able to reproduce the problem on a plain snv_101 install using tst.resize1.d from a snv_102 build. I have logged a separate bug on this but do not yet have the bug ID. Mike On Sun, Nov 16, 2008 at 7:43 AM, Mike Gerdts <[EMAIL PROTECTED]> wrote: > I've posted an updated code review that adds a test case. I've > verified a full clobber build, that bfu delivers the new test case, > and that the test case fails without the fix and succeeds with the > fix. > > http://cr.opensolaris.org/~mgerdts/6750659-2008-11-15/ > > Mike > > > On Wed, Nov 12, 2008 at 9:50 PM, Mike Gerdts <[EMAIL PROTECTED]> wrote: >> I believe that I have a fix for 6750659 ready to go. Can I get a few eyes >> on: >> >> http://cr.opensolaris.org/~mgerdts/6750659-2008-11-12/ >> >> There are only 5 lines of meaningful change. Some background info is >> available at >> >> http://mail.opensolaris.org/pipermail/dtrace-discuss/2008-September/006637.html >> >> Jon Haslam has offered to sponsor this change. >> >> -- >> Mike Gerdts >> http://mgerdts.blogspot.com/ >> > > > > -- > Mike Gerdts > http://mgerdts.blogspot.com/ > -- Mike Gerdts http://mgerdts.blogspot.com/ _______________________________________________ dtrace-discuss mailing list dtrace-discuss@opensolaris.org
