[ 
https://jira.duraspace.org/browse/DS-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26153#comment-26153
 ] 

Andrea Bollini commented on DS-1236:
------------------------------------

Hi Kostas,
some minor issues to fix:
https://github.com/DSpace/DSpace/pull/49/files#L0R127
https://github.com/DSpace/DSpace/pull/49/files#L0R154
refer always to field1 instead of 2 and 3.

It will be useful if you can add a check that assure backward compatibility if 
the new configuration parameters are not present (i.e. if the while loop exit 
with idx == 1 then you should populate the array with the pre-3.0 index names)

Finally, due to some changes in the master branch the pull request cannot be 
automatically merged, can you resolve the merge conflict?
                
> Auto update advance search drop down lists from configuration file
> ------------------------------------------------------------------
>
>                 Key: DS-1236
>                 URL: https://jira.duraspace.org/browse/DS-1236
>             Project: DSpace
>          Issue Type: Improvement
>          Components: JSPUI
>    Affects Versions: 1.8.2
>            Reporter: Kostas Stamatis
>            Assignee: Andrea Bollini
>              Labels: has-patch, has-pull-request
>         Attachments: autosearchfields_patch.diff, README.txt
>
>
> This proposed extension (implemented by National Documentation Centre/EKT - 
> http://www.ekt.gr) allows the automated creation of dropdown menus in advance 
> search according to configuration options.  
> This is not an option in DSpace 1.8.2 since the advanceSearch.jsp includes 
> the options in the select drop down menus in a hardcoded manner.
> USEFULNESS
> ---------------------
> In case you change the search indices in the default dspace.cfg configuration 
> file, the drop down menus in the advance search page are not automatically 
> updated with these new indices. With this extension, you do not have to worry 
> about the advance jsp page since it is automatically updated from the 
> configuration file.
> CONFIGURATION FILES
> ---------------------------------------
> In the default configuration file of DSpace (dspace.cfg) just declare the 
> search indices that you want to have in the drop down menus within advance 
> search page as follows:
> # Declare search indices to appear in drop down menus
> search.index.display.1 = author
> search.index.display.2 = title
> search.index.display.3 = keyword
> search.index.display.4 = abstract
> search.index.display.5 = author
> search.index.display.6 = series
> search.index.display.7 = abstract
> search.index.display.8 = mime
> search.index.display.9 = sponsor
> search.index.display.10 = identifier
> search.index.display.11 = language

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to