[ 
https://jira.duraspace.org/browse/DS-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26140#comment-26140
 ] 

Andrea Bollini commented on DS-1228:
------------------------------------

Hi Kostas,
I suggest to make the following changes:
1) webui.itemdisplay.inclusespace is not necessary, the user can get the same 
result setting only the webui.itemdisplay.separator (i.e. 
webui.itemdisplay.separator = ;  ). You can add a comment near the 
configuration to specify this.
2) this line https://github.com/DSpace/DSpace/pull/48/files#L0R484 could 
produce a NPE if the inclusespace properties is not set. You should use the 
ConfigurationManager.getBooleanProperty instead to avoid this. Anyway, this 
will go out if you agree with 1

Andrea
                
> Concatenate values of multi-value fields in item display
> --------------------------------------------------------
>
>                 Key: DS-1228
>                 URL: https://jira.duraspace.org/browse/DS-1228
>             Project: DSpace
>          Issue Type: Improvement
>          Components: JSPUI
>         Environment: DSpace 1.8.2
>            Reporter: Kostas Stamatis
>              Labels: has-patch, has-pull-request, itemtag
>         Attachments: concatvalues-patch.diff, README.txt
>
>
> This proposed extension (implemented by National Documentation Centre/EKT - 
> http://www.ekt.gr) permits in JSPUI and item display (item tag) to 
> concatenate the multiple values of a field to one line instead of displaying 
> then each one in a seperate line.  
> The configuration is done within dspace.cfg file and the users can select if 
> they want the concatenation or the default line break, the separation 
> character or string and the existence of a non-breaking space before the 
> separator.
> USEFULNESS
> ---------------------
> Sometimens, some fields (usually subject keywords) contain multiple values in 
> a large number than makes the item display have a huge height that makes the 
> record unreadable. Using this extension, you can concatenate the values in 
> one line and thus gain space from the item display screen.
> CONFIGURATION FILES
> ---------------------------------------
> Tag cloud is fully configurable within the default dspace.cfg configuration 
> file of DSpace. The new configuration options are:
> # Customise the DC metadata fields to show in the default simple item view.
> #
> # The form is <schema 
> prefix>.<element>[.<qualifier>|.*][(date)|(link)|(nobreakline)], ...
> #
> # For example:
> #    dc.title               = Dublin Core element 'title' (unqualified)
> #    dc.title.alternative   = DC element 'title', qualifier 'alternative'
> #    dc.title.*             = All fields with Dublin Core element 'title'
> #                             (any or no qualifier)
> #    dc.identifier.uri(link) = DC identifier.uri, render as a link
> #    dc.date.issued(date)   = DC date.issued, render as a date
> #    dc.subject(nobreakline)   = DC subject.keyword, rendered as separated 
> values 
> #                               (see also webui.itemdisplay.inclusespace and 
> webui.itemdisplay.separator options)
> #    "link/date" options can be combined with "nobreakline" option using a 
> space among them i.e "dc.identifier.uri(link nobreakline)"
> #
> # If an item has no value for a particular field, it won't be displayed.
> # The name of the field for display will be drawn from the current UI
> # dictionary, using the key:
> #
> # "metadata.<style>.<field>" or if undefined the key "metadata.<field>"
> #
> # e.g.   "metadata.default.dc.title" or "metadata.default.dc.title"
> #        "metadata.dc.contributor.*" or "metadata.default.dc.contributor.*"
> #        "metadata.dc.date.issued" or "metadata.default.dc.date.issued"
> #
> #webui.itemdisplay.default = dc.title, dc.title.alternative, 
> dc.contributor.*, \
> #                            dc.subject(link nobreakline), 
> dc.date.issued(date), dc.publisher, \
> #                            dc.identifier.citation, 
> dc.relation.ispartofseries, \
> #                            dc.description.abstract, dc.description, \
> #                            dc.identifier.govdoc, dc.identifier.uri(link), \
> #                            dc.identifier.isbn, dc.identifier.issn, \
> #                            dc.identifier.ismn, dc.identifier
> #
> # If nobreakline option is applied for a field in itemdisplay then the 
> following options define the separator string
> # and if we want a space before the separator
> webui.itemdisplay.inclusespace = false
> webui.itemdisplay.separator = ;
> EXAMPLES
> ------------------
> Repository: Helios - NHRF Repository
> URL: http://helios-eie.ekt.gr/EIE/handle/10442/8493
> Note: See keywords field. Values separated by ;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to