On Thu, Aug 16, 2012 at 02:37:56PM -0500, Tim Donohue wrote: > Since the code is voted in, anyone (including the person who initialized > the pull request) can go forth with the merge.
Strictly true: any committer *can*. But we need a consensus on who we would normally expect to do it. Again, I fear that "anyone can" leaves us standing in a circle holding out chairs for each other. My suggestion: ordinarily the person who submitted the pull request should do the merge. There may be a need to fix things up, if other recent merges have impinged on the changes, and the submitter is probably best placed to tidy up. If this doesn't happen within a reasonable interval then any other committer who wants it merged (or just feels like tackling the backlog) can do so. "Reasonable interval" is up to the individual, but I would give the submitter at least 24 hours. > #41 - Salt Password AuthN -> Need volunteer to merge (MarkW you interested?) Will do. > One word of warning, we may want to ensure each merge is "clean" & all > unit tests succeed. > > Currently, the merge of Pull Request #43 has caused unit testing > failures. We may want to wait until those are resolved before the next > merge takes place, otherwise we run the risk of "snowballing" unit test > failures (which could make it potentially difficult to determine which > failures were the result of which commit/merge). OK, I'll watch the change ML for this. -- Mark H. Wood, Lead System Programmer [email protected] Asking whether markets are efficient is like asking whether people are smart.
pgpDmKDuqnB5A.pgp
Description: PGP signature
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
