Mark, A big part of this is really "growing pains" of moving to a more distributed submission system (i.e. GitHub). Everyone is definitely trying to do their best to keep 3.0 on-time.
Though we have to admit that the influx of new submissions (via GitHub) has be *much greater* than most any past releases I can recall. In addition, many of these submissions have come in *all at once* (see below). > What we need is: > > 1.) Pushing the overall contribution freeze date into the future and > 2.) A more concrete and rapid process of voting on any Pull request with > the conclusion being the acceptance of the pull request. I'm not clear how you are suggesting that the Release Schedule should change. We've already done #1 by pushing back the contribution date to Aug 24. Obviously, we're all in agreement that this process would be much more smooth if we had contributions been added in stages (and pull requests submitted gradually). But, unfortunately, it's mostly been a bunch of pull requests all opened in the last week or so. If you look closely, of the 22 currently open pull requests, 16 of them have been opened in the last 8 days. (Though, you are correct that a few of the other 6 have been sitting there for a few months) > Given the Pull Requests have been open for some time and they have been > talked about over several meetings, there is not a clear procedure for > accepting and closing them given theres been no major complaints. This > is happening on all the Requests. The vote required in the processes > described here > (https://wiki.duraspace.org/display/DSPACE/Developer+Voting+Procedures) > does not have a clear "process", especially now that we are using Pull > Requests. Should a vote thread be opened in email?, should folks vote > in the committer meeting in IRC? should they vote in the Pull Request > comments themselves, or should they vote in the JIRA task? Its not > formalized. The voting procedures currently say that "Votes can be called either during meetings or via email." However, obviously JIRA comments send automated emails to dspace-devel, so that's another option for voting. I'd be fine with finalizing this more if we all felt it worthwhile. Currently it is left a little open-ended to allow for flexibility in calling votes. > It is critical that we review the list of existing pull requests and > begin work to accept those that have been there for some time. I propose > this process should be similar to the JIRA review process: > > a.) Pull Requests that can be accepted immediately should be. > b.) Large Pull Requests needing a vote should be voted on in IRC in the > meeting and accepted, rejected or identified as still needing work. > c.) Pull requests still needing work should be identified as such by a > [IN PROCESS] prefix in their title > d.) New and Existing Pull Requests ready for acceptance review should be > marked as such with a [COMPLETE] prefix in their title > e.) Prior to accepting, the reviewer that will complete the accept > should remove the [COMPLETE] prefix and accept it. > f.) In each committer meeting we are responsible for reviewing a number > of pull requests starting with the earliest, with the intent to be decisive. > g.) If there is a problem or opposition with a committed contribution > during the test phase, it would need to be rolled back. I see you've already started down this route based on the recent changes in Pull Request titles. I think this is fine & worth a try. A few minor quibbles: * One thing to note is that this is seemingly duplicating JIRA "status" functionality into the titles of Pull Requests. I think this is OK if it is useful to all. Just something to note. * I'd suggest renaming "[COMPLETE]" to something like "[READY FOR REVIEW]" or "[NEEDS REVIEW]". I don't think any code is "complete" until it is approved & committed. Again, aligning this with JIRA statuses seems like it would be good. Those are just my immediate thoughts. Again, would be good to hear from others. - Tim ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
