Nestor Oviedo created DS-1196:
---------------------------------

             Summary: Xmlworkflow multiple action configuration not deleting 
claimed tasks
                 Key: DS-1196
                 URL: https://jira.duraspace.org/browse/DS-1196
             Project: DSpace
          Issue Type: Bug
    Affects Versions: 1.8.2, 3.0
            Reporter: Nestor Oviedo


There is a bug in the XmlWorkflowManager's processOutcome() method that relies 
in not deleting the already processed CalimTask tuple from the DB. This happens 
when there are two or more <action> in one <step> inside the xmlworkflow config.

For example, with the following config:
        ...
        <step id="step1" role="role1" userSelectionMethod="claimaction">
            <actions>
                <action id="action1"/>
                <action id="action2"/>
            </actions>
        </step>
        ...
When the claimaction is executed, it creates a ClaimedTask with info about the 
user, the step and the action to be activated, which in this case would be the 
first one: action1.
Whe action1 is completed, the XmlWorkflowManager::processOutcome() method is 
executed to determine the next action (which will be action2) and then the 
manager creates the ClaimedTask for this second action, but it never deletes 
the old ClaimedTask.

As a simple workaround for this, I added the following code:
   ClaimedTask task = ClaimedTask.findByWorkflowIdAndEPerson(c, wfi.getID(), 
user.getID());
   deleteClaimedTask(c, wfi, task);
before creating the new ClaimedTask (line 197 of XmlWorkflowManager).

Looking forward for comments


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to