[
https://jira.duraspace.org/browse/DS-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18411#action_18411
]
Tim Donohue commented on DS-777:
--------------------------------
As an example of how we could implement the above, we could change
PackageUtils.translateGroupNameForExport() as follows...
We'd change...
if(dso==null)
{
// Just log a warning -- it's possible this Group was not
cleaned up when the associated DSpace Object was removed.
// So, we don't want to throw an error and stop all other
processing.
log.warn("Unable to translate Internal ID to Handle in group
named '" + groupName + "' as DSpace Object (ID='" + objID + "', type ='" +
objType + "') no longer exists.");
return null;
}
to something like:
if(dso==null)
{
String dummyName = "GROUP_" + Utils.generateKey() + "_" +
objType + "_" + groupType;
log.warn("warning message about how group was renamed as its
associated object couldn't be found");
return dummyName;
}
So, it's essentially just a couple line fix.
> PackageUtils.translateGroupNameForExport returns null unexpectedly
> ------------------------------------------------------------------
>
> Key: DS-777
> URL: https://jira.duraspace.org/browse/DS-777
> Project: DSpace
> Issue Type: Bug
> Components: DSpace API
> Affects Versions: 1.7.0
> Reporter: Mark H. Wood
> Assignee: Tim Donohue
> Attachments: METSRightsCrosswalk-updated.patch
>
>
> We have a Community with a ResourcePolicy referring to Group
> COLLECTION_22_SUBMITTER, which seems to have been hand-created since the
> automatic naming would have yielded COLLECTION_number_SUBMIT. There is no
> Collection with ID 22, so PackageUtils.translateGroupNameForExport() returns
> null, and we wind up with <rights:UserName USERTYPE="GROUP" /> which causes a
> CrosswalkInternalException on ingestion.
> I think that, for a Group named type_id_whatever, if we cannot find an object
> of the given type with the given id, then we should consider the input not a
> match to the generated-name pattern and return the unaltered name. We should
> *never* return null or a zero-length
> String; we should *always* return either the unaltered input or a correct
> translation.
> Is there a reason for returning null here that I haven't seen?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
