[
https://jira.duraspace.org/browse/DS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18323#action_18323
]
Tim Donohue commented on DS-748:
--------------------------------
Part of this seems to have been broken in dri2xhtml/DIM-Handler.xsl in 1.6.0 by
the commits around DS-588 (Patch for SFX (OpenURL resolver)). It seems the
"mostly valid" COinS was replaced with SFX specific code (which only generates
valid COinS when SFX is enabled -- otherwise it generates a completely blank
COinS entry).
DIM-Handler.xsl code:
https://fisheye3.atlassian.com/browse/dspace/dspace/trunk/dspace-xmlui/dspace-xmlui-webapp/src/main/webapp/themes/dri2xhtml/DIM-Handler.xsl?r=HEAD
However in the new 'dri2xhtml-alt/aspect/artifactbrowser/COinS.xsl' the older
COinS code exists which at least ensures that all Item metadata is still
properly embedded into the COinS object.
COinS.xsl code:
https://fisheye3.atlassian.com/browse/dspace/dspace/trunk/dspace-xmlui/dspace-xmlui-webapp/src/main/webapp/themes/dri2xhtml-alt/aspect/artifactbrowser/COinS.xsl?r=HEAD
But, in both themes, "dryad.org" is still hardcoded, and the format identifier
'dc' is still used. So, there are still some underlying problems here. I'm
just noting the inconsistencies that now exist in DIM-Handler.xsl vs.
COinS.xsl, based on which Theme you are using.
> COinS in XMLUI has invalid referrer Id and dc metadata; spans are not
> properly constructed
> ------------------------------------------------------------------------------------------
>
> Key: DS-748
> URL: https://jira.duraspace.org/browse/DS-748
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0, 1.6.1, 1.6.2
> Reporter: Bill Hays
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1. The referrerId is hard-coded as "dryad.org" and there doesn't seem to be
> a reasonably simple way to either pull a HTTP request parameter or a DSpace
> config property value and use that instead since the xsl transform at that
> point cannot reach the dri document.
> 2. The format identifier "dc" implies strict Dublin Core according to the
> OpenURL spec and the COinS online docs. Selectively using qdc seems to go
> against that. But trying to crosswalk qdc to dc also seems very difficult in
> the Manakin context.
> 3. What can be easily fixed is the wrapping of the COinS spans around item
> titles which clearly goes against basic practice as discussed in the COinS
> online docs. The problem here is that mouse rollovers inappropriately
> display popups of the context objects. It is also unclear to me whether the
> placing of multiiple COinS on result screens is sensible across different
> consuming applications for COinS. The spans should have not content except
> some whitespace to force the existence of a closing tag.
> These first two issues don't appear to be easy to fix and there is no way to
> turn off COinS without editing the DIMHandler xsl. So, by default, any given
> DSpace instance will be rendering invalid COinSs, though they may work for
> certain COinS-consuming applications. If no one can fix these issues in the
> near term, I recommend that the COinS implementation be removed from the
> trunk and a separate patch be made available with instructions for
> customizations for those wanting this feature.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
