[ 
http://jira.dspace.org/jira/browse/DS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robin Taylor closed DS-546.
---------------------------

    Documentation Status: Not Required  (was: Needed)
              Resolution: Fixed

Changed Administrative sitemap to only display Notices generated in the 
Administrative aspect. Committed to trunk, revision 5346.

> XMLUI 'Notice's are always added by the Administrative aspect even if the 
> content was generated by another aspect.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: DS-546
>                 URL: http://jira.dspace.org/jira/browse/DS-546
>             Project: DSpace 1.x
>          Issue Type: Bug
>          Components: XMLUI
>    Affects Versions: 1.5.2
>            Reporter: Robin Taylor
>            Assignee: Robin Taylor
>            Priority: Minor
>             Fix For: 1.7.0
>
>
> Not sure if this qualifies as a bug. I am looking for some comments or 
> advice...
> The XMLUI has a utility class  
> org.dspace.app.xmlui.aspect.general.NoticeTransformer  that facilitates 
> adding a simple 'Notice' div to a page.  Unfortunately this transformer is 
> always invoked by the Administrative sitemap...
> <map:match type="WildcardParameterMatcher" pattern="true">
>        <map:parameter name="parameter-name" value="notice"/>
>        <map:parameter name="notice" value="{flow-attribute:notice}"/>
>                <map:transform type="notice">
> This prevents the reuse of  NoticeTransformer  in other aspects and breaks 
> the notion of each aspect being independent.  Either the class should be 
> moved out of the 'general' package and into an 'administrative' package, or, 
> the class should only be invoked in the Administrative sitemap if the content 
> was generated in the Administrative aspect. This could be achieved by adding 
> a match against the url ...
> <map:match pattern="admin/**">
> This would be my preferred option but it might break any customisations that 
> have been done relying on the fact that the Admin aspect would always add any 
> Notices.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to