[
http://jira.dspace.org/jira/browse/DS-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Donohue updated DS-638:
---------------------------
Assignee: Richard Rodgers
Status: Open (was: Received)
Jose,
Thanks for providing us with your code. I haven't had a chance to fully review
it, yet, but it's good to make this code more visible to the community.
One thing to be aware of -- MIT (specifically Richard Rodgers) is working on a
flexible Framework for integration of "Curation Tasks" into DSpace. This
framework is likely to be in place for 1.7 --
https://wiki.duraspace.org/display/DSPACE/CurationTaskProposal
As this feature falls under that "Curation Tasks" idea, I'm assigning this
issue to Richard Rodgers (hope you don't mind, Richard). I'm sure he can
comment further on whether this code would need to be reworked to support the
Curation Tasks plan. Hopefully, at the very least it can help to inform this
work to make it even more extensible/flexible.
Thanks again.
> check files on input for viruses, and verify file format
> ---------------------------------------------------------
>
> Key: DS-638
> URL: http://jira.dspace.org/jira/browse/DS-638
> Project: DSpace 1.x
> Issue Type: New Feature
> Components: JSPUI
> Affects Versions: 1.6.2
> Environment: to use this patch you will need to have ClamAV, and
> jhove installed on your system.
> Reporter: Jose Blanco
> Assignee: Richard Rodgers
> Priority: Minor
> Attachments: java_files.zip, jhove_config_files.zip, jsp_files.zip
>
>
> This patch uses JHOVE to provide rough-and-ready format checking by
> identifying that the file/bitstream extension matches formats verifiable by
> JHOVE. (Currently DSpace accepts a deposit's file extension as gospel, so a
> user could tack a ".txt" extension onto a GIF and DSpace would assign the
> incorrect format to the file based on that incorrect extension.)
> This patch also also contains code to check the file for the presence of
> viruses.
> In order to use this patch you must have jhove and ClamAV installed on your
> system.
> Important notes:
> (1) HTML identification has proved unreliable ( by jhove ), so this patch
> does not return accurate results for that
> file format.
> (2) This code does not fully incorporate JHOVE's validation functions; it
> only verifies that what depositors intended to submit is in fact what they
> submitted.
> The following are returned messages when an error is detected:
> Text in [brackets] is a returned value, ALLCAPS can/should be modified to
> reflect your current installation.
> Questionable AIFF, GIF, JPG, PDF, TIF, WAVE, XML:
> DSPACE could not verify that your file is a valid [file_format_extension].
> Please check the file format and ".[file_format_extension]" extension.
> Questionable TXT:
> DSPACE found the text file you are trying to upload is neither UTF-8 nor
> ASCII. Please verify that your file is in the format you wanted.
> Spaces in filenames ( this is an additional check ):
> The file name contains spaces; this is not recommended. If possible, please
> replace spaces with underscores: "_".
> Virus detected:
> DSPACE detected a virus in this file. Please repair it and resume the
> deposit. If you need assistance, please contact us: EMAIL_ADDRESS.
> To get the patch working:
> Add the jhove conf files to
> [dspace]/jhove direcoty
> Here are the conf files:
> jhove-aiff.conf
> jhove-ascii.conf
> jhove-gif.conf
> jhove-jpeg.conff
> jhove-pdf.conf
> jhove-tiff.conf
> jhove-utf8.conf
> jhove-wave.conf
> jhove-xml.conf
> Also the following files were changed:
> dspace-api/src/main/java/org/dspace/submit/step/UploadStep.java
> dspace-jspui/dspace-jspui-api/src/main/java/org/dspace/app/webui/submit/step/JSPUploadStep.java
> dspace-api/src/main/java/org/dspace/content/FormatIdentifier.java
> dspace/modules/jspui/src/main/webapp/submit/get-file-format.jsp ( locally
> customized )
> dspace/modules/jspui/src/main/webapp/submit/upload-error-virus.jsp ( new file
> - placed in locally modified area for the jspui interface)
> These files are attached with this patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
