[ 
http://jira.dspace.org/jira/browse/DS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kim Shepherd updated DS-548:
----------------------------

    Attachment: DS-548.patch

This patch resolves the problem with DescribeStep.readNames(), and also 
attempts to fix a related issue in DescribeStep.readText(), where 
authority/confidence values were not being removed upon removal of the metadata 
itself.

I have tested with success but would also appreciate peer review from people 
using a text field as authority controlled metadata (rather than name)

> Removing repeatable values in DescribeStep does not properly test for 
> authority control
> ---------------------------------------------------------------------------------------
>
>                 Key: DS-548
>                 URL: http://jira.dspace.org/jira/browse/DS-548
>             Project: DSpace 1.x
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.6.0
>            Reporter: Kim Shepherd
>            Assignee: Kim Shepherd
>             Fix For: 1.6.1, 1.7
>
>         Attachments: DS-548.patch
>
>
> Attempting to remove a repeatable parameter of input type "name" in 
> DescribeStep causes the following exception to be thrown (exception only 
> thrown in JSPUI, though the problem exists in 
> org.dspace.submit.step.DescribeStep) unless that value is configured for 
> authority control:
> ERROR org.dspace.app.webui.servlet.SubmissionController @ Error loading step 
> class'org.dspace.submit.step.DescribeStep':
> java.lang.IndexOutOfBoundsException: Index: 1, Size: 0
>         at java.util.LinkedList.entry(LinkedList.java:365)
>         at java.util.LinkedList.remove(LinkedList.java:357)
>         at 
> org.dspace.submit.step.DescribeStep.readNames(DescribeStep.java:538)
> The linked list removals for "auth" and "conf" need to be wrapped in an 
> if(isAuthorityControlled) test
> Similar problems exist in readText, and possibly other methods. Will submit a 
> patch after some more testing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to