[
http://jira.dspace.org/jira/browse/DS-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Donohue reassigned DS-399:
------------------------------
Assignee: Tim Donohue
This issue was discussed during the Developer meeting on Dec 9, 2009.
Consensus was that the License should only be plain text and should not be
checking for well-formed XML or XHTML (which is what is currently happening in
XMLUI). Assigned to Tim Donohue to investigate further.
[15:55] <tdonohue> http://jira.dspace.org/jira/browse/DS-399
[15:55] <ClaudiaJuergen> interesting thought the i18n troubles were only on
jspui
[15:55] <mdiggory> Firefox...
[15:55] <ClaudiaJuergen> tdonohue: only vaguely
[15:55] <mdiggory> and locale switcher cause problems
[15:56] <mdiggory> it tends to run wild
[15:56] <tdonohue> DS-399: Not sure if this is an actual bug or not. I wonder
if it's just complaining about the unclosed bracket (<)
[15:56] <mdiggory> ok, I'm convinced... needs fixing +1
[15:57] <mhwood> Those should be character-entity encoded on the way in, so it
shouldn't matter what they are -- but apparently it does.
[15:57] <mdiggory> per 399, yes, but XMLUI will catch licensing format issues.
[15:57] <mdiggory> not JSPUI... this a parity difference
[15:58] <mdiggory> XMLUI expects all fields to be wellformed
[15:58] <lcs> the license is stored as a bitstream, probably UTF-8 character
stream.
[15:58] <tdonohue> yes. mdiggory is right...XMLUI is seeing the "<" and
expecting wellformed XML
[15:58] <tdonohue> (or that's what I think could be happening)
[15:59] <mdiggory> it is the collection editor reflects this problem to the
Collection Admin
[15:59] <mdiggory> in the XMLUI
[16:00] <tdonohue> I just removed the "<" from the collection license at
http://eldorado2.tu-dortmund.de:8080/xmlui/handle/123456789/11, and the error
disappears
[16:01] <tdonohue> It looks like it handles i18n fine...it's just expecting
well formed XML when it sees either < or >
[16:02] <ClaudiaJuergen> right, more in the kind of usability might confuse
newbie delegated administrators
[16:02] <tdonohue> So, is it more that it text of the warning should change?
[16:03] <mdiggory> XMLUI supports xhtml tags in the content of these feilds and
requires it to be xhtml, not html or unclised tags. Its been in XMLUI since the
beginning of XMLUI
[16:03] <ClaudiaJuergen> yes
[16:03] <mdiggory> unclised = unclosed
[16:03] <mhwood> Brokets need to be transformed to <, > when entering an
XML context.
[16:03] <mdiggory> no, mostly xml content should be well formed
[16:04] <mdiggory> not escaped
[16:04] <lcs> the license is free text, not xml or html. it should be escaped
as mhwood says.
[16:04] <tdonohue> mhwood. The problem there is that the XMUI is trying to
allow you to enter XHTML into those fields (to provide formatting if you wish).
Escaping those characters would remove that capability
[16:04] <caryn> text doesn't indicate anywhere that this can be marked up...
[16:04] <mhwood> Ewww
[16:05] <mdiggory> The UI behavior treats anything edited in a form field on
that page the same
[16:05] <ClaudiaJuergen> thought the license could not be marked u
[16:05] <mdiggory> in XMLUI, its a feature
[16:05] <lcs> deposit license is stored as a bitstream of type "License" (ewww)
with mimetype text/plain..
[16:05] <ClaudiaJuergen> only the descriptive elements
[16:05] <mdiggory> then put plain text in the form field
[16:06] <caryn> if it's well-formed, can that field display marked up text? or,
do you get the <, >
[16:07] <mdiggory> it will display as markup if well formed
[16:07] <mdiggory> but, because he License file itself is text/plain, your
browser will not rtreat it as such
[16:07] <lcs> it _should_ display literal <foo> if you enter <foo> in the
license field.
[16:07] <mdiggory> as lcs points out
[16:08] <mdiggory> recommend that tdonohue change this when he looks at
removing it as well
[16:08] <ClaudiaJuergen> ok, it's late here, bedtime for me
[16:08] <ClaudiaJuergen> bye
[16:08] <caryn> got it - also, the special characters won't parse when the item
is downloaded as a bundle...
[16:08] <mdiggory> from the XMLUI presentation
[16:08] <tdonohue> I'll look into DS-399 as well. So we are agreed it should be
plain text always
[16:09] <ClaudiaJuergen> +1 for that
[16:09] <caryn> +1 plain text
[16:09] * ClaudiaJuergen ([email protected]) Quit ("Miranda IM!
Smaller, Faster, Easier. http://miranda-im.org";)
[16:09] <mdiggory> I suppose
[16:09] <mhwood> Problem seems to be that it's undecided whether this hunk of
text is XHTML or plain. We can be clever and try to detect what is markup and
what is not (ick!) or we can ask the user to specify (and then it's his
problem) or we can tell the user what it is, one way or the other.
[16:09] <lcs> +1 text/plain
[16:09] <tdonohue> we're well over time. Call it a day?
[16:09] <mhwood> +1 text/plain, be sure the user knows
[16:10] <mdiggory> mhwood: the UI does detect it, but the expectation is that
if your putting in tags, your wanting html/xhtml
[16:10] <caryn> if it's not in plain text, then the downloaded license file
should have an extension...
[16:10] <caryn> plain text is a bit more straightforward
> Special characters in collection license lead to parse error
> ------------------------------------------------------------
>
> Key: DS-399
> URL: http://jira.dspace.org/jira/browse/DS-399
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0
> Reporter: Claudia Jürgen
> Assignee: Tim Donohue
>
> Having special chars in the collection specific license lead to markup
> warnings
> During submission granting it:
> Error unable to parse: Error on line 2: The content of elements must consist
> of well-formed character data or markup.
> This is a test license. Some special chars äöüß#<&
> During edit collection:
> * Error on line 2: The content of elements must consist of well-formed
> character data or markup.
> The license itself is stored ok.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
