[
http://jira.dspace.org/jira/browse/DS-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10900#action_10900
]
Robin Taylor commented on DS-383:
---------------------------------
Apologies for not providing a patch with this. I do think that the correct
coding would be to change the context.commits scattered throughout the XMLUI to
be context.completes, and then only have a context.abort in the filter that
would close any stray connections eg if an Exception had occured. This is what
happens in the JSPUI. However, this is a risky change as it relies on having
context.completes where they should be. If you don't mind waiting I'll do this
on our local installation and add a patch once I'm confident it works ok.
> Auto commit functionality not working correctly in XMLUI
> --------------------------------------------------------
>
> Key: DS-383
> URL: http://jira.dspace.org/jira/browse/DS-383
> Project: DSpace 1.x
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.2
> Reporter: Robin Taylor
> Assignee: Stuart Lewis
>
> My understanding is that Dspace provides transactional processing by setting
> the database connection to auto-commit=false and doing a 'commit' once all
> processing has completed successfully. However, Manakin has a filter called
> DSpaceCocoonServletFilter which contains the following code that runs after
> the request has been passed on for further processing...
> // Close out the DSpace context no matter what.
> ContextUtil.closeContext(realRequest);
> This appears to run, commiting changes to the database, even if an Exception
> is thrown in the main code.
> The code needs to be more intelligent and only do a commit to the database
> where appropriate. The current catch-all approach causes problems in the
> event of a failure and also prevents any sort of multiple items upload, eg
> from a reference manager.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
