Kieran Bingham, Thu, Jun 18, 2020 18:23:14 +0200:
> On 02/04/2020 19:34, Alex Riesen wrote:
> > --- a/drivers/media/i2c/adv748x/adv748x-dai.c
> > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c
> > @@ -117,11 +117,22 @@ static int adv748x_dai_set_fmt(struct snd_soc_dai
> > *dai, unsigned int fmt)
> >
> > static int adv748x_dai_startup(struct snd_pcm_substream *sub, struct
> > snd_soc_dai *dai)
> > {
> > + int ret;
> > struct adv748x_state *state = state_of(dai);
> >
> > if (sub->stream != SNDRV_PCM_STREAM_CAPTURE)
> > return -EINVAL;
> this looks quite bunched up so :
>
> Newline...
Will do.
> > - return set_audio_pads_state(state, 1);
> > + ret = set_audio_pads_state(state, 1);
> > + if (ret)
> > + goto fail;
>
> With no action required to cleanup here, I would just
> return ret;
> and remove the fail: label.
Of course.
> > + ret = clk_prepare_enable(mclk_of(state));
> > + if (ret)
> > + goto fail_pwdn;
>
> newline...
>
> > + return 0;
>
> newline...
>
> Other than that:
>
> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Thanks!
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
