On Thu, Apr 30, 2020 at 10:09:31AM +0200, Greg KH wrote:
> On Thu, Apr 30, 2020 at 10:07:35AM +0200, Greg KH wrote:
> > On Thu, Apr 30, 2020 at 10:00:12AM +0200, Christian Gromm wrote:
> > > This patch moves the MOST USB adapter driver to the stable branch.
> > > It is a follow-up to commit <b276527>.
> > 
> > That's not how to refer to git commit ids.  Please see the
> > submitting-patches.rst file for the proper format.
> 
> Also, you might want to run this driver by the usb mailing list, I don't
> think it's been audited by anyone, myself included, for any usb specific
> things.
> 
> As proof, I see at least one thing that should be changed...

Ok, lots of little things, I don't think I ever actually read this
driver before, sorry about that...

Please post it as a patch that just adds the file, which will make it
much easier to review and respond to it.

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to