[PATCH] staging: rtl8723bs: hal: Remove NULL check before kfree

[Simran Singhal]

NULL check before kfree is unnecessary so remove it.

The following Coccinelle script was used to detect this:
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;

Signed-off-by: Simran Singhal <singhalsimr...@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c 
b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
index 1e8b61443408..cf68193a167f 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
@@ -480,10 +480,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
                precvpriv->precv_buf = NULL;
        }
 
-       if (precvpriv->pallocated_recv_buf) {
-               kfree(precvpriv->pallocated_recv_buf);
-               precvpriv->pallocated_recv_buf = NULL;
-       }
+       kfree(precvpriv->pallocated_recv_buf);
+       precvpriv->pallocated_recv_buf = NULL;
 
 exit:
        return res;
@@ -518,8 +516,6 @@ void rtl8723bs_free_recv_priv(struct adapter *padapter)
                precvpriv->precv_buf = NULL;
        }
 
-       if (precvpriv->pallocated_recv_buf) {
-               kfree(precvpriv->pallocated_recv_buf);
-               precvpriv->pallocated_recv_buf = NULL;
-       }
+       kfree(precvpriv->pallocated_recv_buf);
+       precvpriv->pallocated_recv_buf = NULL;
 }
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel