Hi Dan, Thanks for the patch.
On Wed, 2020-01-08 at 08:35 +0300, Dan Carpenter wrote: > This can't be NULL and we've already dereferenced it so let's remove > the check. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > --- > drivers/staging/media/hantro/hantro_v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/hantro/hantro_v4l2.c > b/drivers/staging/media/hantro/hantro_v4l2.c > index 85af1b96fd34..0198bcda26b7 100644 > --- a/drivers/staging/media/hantro/hantro_v4l2.c > +++ b/drivers/staging/media/hantro/hantro_v4l2.c > @@ -688,7 +688,7 @@ static int hantro_start_streaming(struct vb2_queue *q, > unsigned int count) > return ret; > > err_codec_exit: > - if (ctx->codec_ops && ctx->codec_ops->exit) > + if (ctx->codec_ops->exit) Since you are here, can you remove the other unneeded checks in the driver? We are assuming ctx->codec_op is non-NULL, so perhaps a check in .probe, to check it explicitly would be better. Thanks, Ezequiel _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
