On Thu, Nov 07, 2019 at 05:07:56PM +0200, Beniamin Bia wrote:
> +static int ad7091r_set_mode(struct ad7091r_state *st, enum ad7091r_mode mode)
> +{
> +     int ret, conf;
> +
> +     switch (mode) {
> +     case AD7091R_MODE_SAMPLE:
> +             conf = 0;
> +             break;
> +     case AD7091R_MODE_COMMAND:
> +             conf = AD7091R_REG_CONF_CMD;
> +             break;
> +     case AD7091R_MODE_AUTOCYCLE:
> +             conf = AD7091R_REG_CONF_AUTO;
> +             break;
> +     default:
> +             ret = -EINVAL;
> +             break;

return -EINVAL;

> +     }
> +
> +     ret = regmap_update_bits(st->map, AD7091R_REG_CONF,
> +                              AD7091R_REG_CONF_MODE_MASK, conf);


otherwise conf is uninitialized.

> +     if (ret)
> +             return ret;
> +
> +     st->mode = mode;
> +
> +     return ret;

return 0;

> +}
> +
> +static int ad7091r_set_channel(struct ad7091r_state *st, unsigned int 
> channel)
> +{
> +     unsigned int foo;

Use unsigned int dummy.

> +     int ret;
> +

Otherwise it looks ok to me.  (Not a domain expert).

regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to