On Thu, Oct 10, 2019 at 06:39:23AM +0300, Wambui Karuga wrote:
>       if (is_primary_adapter(adapter))
>               DBG_871X("IsBtDisabled =%d, IsBtControlLps =%d\n", 
> hal_btcoex_IsBtDisabled(adapter), hal_btcoex_IsBtControlLps(adapter));
>  
> -     if ((adapter_to_pwrctl(adapter)->bFwCurrentInPSMode == true)
> -             && (hal_btcoex_IsBtControlLps(adapter) == false)
> +     if ((adapter_to_pwrctl(adapter)->bFwCurrentInPSMode)
> +             && !(hal_btcoex_IsBtControlLps(adapter))

Delete the extra parentheses as well, because they don't make sense when
we remove the == false comparison.  It's part of doing "one thing" is to
the whole thing and not leave bits undone.

                && !hal_btcoex_IsBtControlLps(adapter)

>               ) {
>               u8 bEnterPS;
>  
> @@ -2047,7 +2047,7 @@ static int rtw_check_join_candidate(struct mlme_priv 
> *mlme
>  
>  
>       /* check bssid, if needed */
> -     if (mlme->assoc_by_bssid == true) {
> +     if (mlme->assoc_by_bssid) {
>               if (memcmp(competitor->network.MacAddress, mlme->assoc_bssid, 
> ETH_ALEN))
>                       goto exit;
>       }
> @@ -2805,7 +2805,6 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 
> *pie, uint ie_len, u8 channe
>       struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
>       u8 cbw40_enable = 0;
>  
> -
>       if (!phtpriv->ht_option)
>               return;
>  
> @@ -2815,7 +2814,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 
> *pie, uint ie_len, u8 channe
>       DBG_871X("+rtw_update_ht_cap()\n");
>  
>       /* maybe needs check if ap supports rx ampdu. */
> -     if ((phtpriv->ampdu_enable == false) && (pregistrypriv->ampdu_enable == 
> 1)) {
> +     if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) {

Same.

>               if (pregistrypriv->wifi_spec == 1) {
>                       /* remove this part because testbed AP should disable 
> RX AMPDU */
>                       /* phtpriv->ampdu_enable = false; */

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to