On Wed, 2019-10-09 at 22:48 +0200, Julia Lawall wrote:
> On Wed, 9 Oct 2019, Jules Irenge wrote:
> > Fix multiple assignments warning " check
> >  issued by checkpatch.pl tool:
> > "CHECK: multiple assignments should be avoided".
[]
> > diff --git a/drivers/staging/qlge/qlge_dbg.c 
> > b/drivers/staging/qlge/qlge_dbg.c
[]
> > @@ -141,8 +141,10 @@ static int ql_get_serdes_regs(struct ql_adapter *qdev,
> >     u32 *direct_ptr, temp;
> >     u32 *indirect_ptr;
> > 
> > -   xfi_direct_valid = xfi_indirect_valid = 0;
> > -   xaui_direct_valid = xaui_indirect_valid = 1;
> > +   xfi_indirect_valid = 0;
> > +   xfi_direct_valid = xfi_indirect_valid;
> > +   xaui_indirect_valid = 1;
> > +   xaui_direct_valid = xaui_indirect_valid
> 
> Despite checkpatch, I think that the original code was easier to
> understand.

It'd likely be easier to understand if all the
<foo>_valid uses were bool and the ql_get_both_serdes
<foo>_valid arguments were change to bool from
unsigned int as well.

btw: qlge likely is going to be deleted and not updated.

---
 drivers/staging/qlge/qlge_dbg.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 7e16066a3527..90ab37d4c49d 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -112,7 +112,7 @@ static int ql_read_serdes_reg(struct ql_adapter *qdev, u32 
reg, u32 *data)
 
 static void ql_get_both_serdes(struct ql_adapter *qdev, u32 addr,
                        u32 *direct_ptr, u32 *indirect_ptr,
-                       unsigned int direct_valid, unsigned int indirect_valid)
+                       bool direct_valid, bool indirect_valid)
 {
        unsigned int status;
 
@@ -136,14 +136,12 @@ static int ql_get_serdes_regs(struct ql_adapter *qdev,
                                struct ql_mpi_coredump *mpi_coredump)
 {
        int status;
-       unsigned int xfi_direct_valid, xfi_indirect_valid, xaui_direct_valid;
-       unsigned int xaui_indirect_valid, i;
+       bool xfi_direct_valid = false, xfi_indirect_valid = false;
+       bool xaui_direct_valid = true, xaui_indirect_valid = true;
+       unsigned int i;
        u32 *direct_ptr, temp;
        u32 *indirect_ptr;
 
-       xfi_direct_valid = xfi_indirect_valid = 0;
-       xaui_direct_valid = xaui_indirect_valid = 1;
-
        /* The XAUI needs to be read out per port */
        status = ql_read_other_func_serdes_reg(qdev,
                        XG_SERDES_XAUI_HSS_PCS_START, &temp);
@@ -152,7 +150,7 @@ static int ql_get_serdes_regs(struct ql_adapter *qdev,
 
        if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) ==
                                XG_SERDES_ADDR_XAUI_PWR_DOWN)
-               xaui_indirect_valid = 0;
+               xaui_indirect_valid = false;
 
        status = ql_read_serdes_reg(qdev, XG_SERDES_XAUI_HSS_PCS_START, &temp);
 
@@ -161,7 +159,7 @@ static int ql_get_serdes_regs(struct ql_adapter *qdev,
 
        if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) ==
                                XG_SERDES_ADDR_XAUI_PWR_DOWN)
-               xaui_direct_valid = 0;
+               xaui_direct_valid = false;
 
        /*
         * XFI register is shared so only need to read one
@@ -176,18 +174,18 @@ static int ql_get_serdes_regs(struct ql_adapter *qdev,
                /* now see if i'm NIC 1 or NIC 2 */
                if (qdev->func & 1)
                        /* I'm NIC 2, so the indirect (NIC1) xfi is up. */
-                       xfi_indirect_valid = 1;
+                       xfi_indirect_valid = true;
                else
-                       xfi_direct_valid = 1;
+                       xfi_direct_valid = true;
        }
        if ((temp & XG_SERDES_ADDR_XFI2_PWR_UP) ==
                                        XG_SERDES_ADDR_XFI2_PWR_UP) {
                /* now see if i'm NIC 1 or NIC 2 */
                if (qdev->func & 1)
                        /* I'm NIC 2, so the indirect (NIC1) xfi is up. */
-                       xfi_direct_valid = 1;
+                       xfi_direct_valid = true;
                else
-                       xfi_indirect_valid = 1;
+                       xfi_indirect_valid = true;
        }
 
        /* Get XAUI_AN register block. */

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to