On Tue, Oct 08, 2019 at 08:50:39PM -0700, Chandra Annamaneni wrote:
> diff --git a/drivers/staging/kpc2000/kpc2000_spi.c 
> b/drivers/staging/kpc2000/kpc2000_spi.c
> index 3be33c4..a20f2d7 100644
> --- a/drivers/staging/kpc2000/kpc2000_spi.c
> +++ b/drivers/staging/kpc2000/kpc2000_spi.c
> @@ -30,19 +30,27 @@
>  #include "kpc.h"
>  
>  static struct mtd_partition p2kr0_spi0_parts[] = {
> -     { .name = "SLOT_0",     .size = 7798784,                .offset = 0,    
>             },
> -     { .name = "SLOT_1",     .size = 7798784,                .offset = 
> MTDPART_OFS_NXTBLK},
> -     { .name = "SLOT_2",     .size = 7798784,                .offset = 
> MTDPART_OFS_NXTBLK},
> -     { .name = "SLOT_3",     .size = 7798784,                .offset = 
> MTDPART_OFS_NXTBLK},
> -     { .name = "CS0_EXTRA",  .size = MTDPART_SIZ_FULL,       .offset = 
> MTDPART_OFS_NXTBLK},
> +     { .name = "SLOT_0",     .size = 7798784,        .offset = 0,},
> +     { .name = "SLOT_1",     .size = 7798784,        .offset =
> +                                                      MTDPART_OFS_NXTBLK},

This looks worse than the original code...  :(  You could maybe make it
a little bit tighter if you used space characters.

        { .name = "SLOT_0",    .size = 7798784,          .offset = 0,           
     },
        { .name = "SLOT_1",    .size = 7798784,          .offset = 
MTDPART_OFS_NXTBLK},
        { .name = "SLOT_2",    .size = 7798784,          .offset = 
MTDPART_OFS_NXTBLK},
        { .name = "SLOT_3",    .size = 7798784,          .offset = 
MTDPART_OFS_NXTBLK},
        { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset = 
MTDPART_OFS_NXTBLK},

It still goes over 80 characters, but that's okay.  Or we could just
leave the original code as is.

[ snip ]

>  static struct flash_platform_data p2kr0_spi1_pdata = {
>       .name =         "SPI1",
>       .nr_parts =     ARRAY_SIZE(p2kr0_spi1_parts),
> @@ -165,7 +174,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int 
> idx)
>       u64 val;
>  
>       addr += idx;
> -     if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0))
> +     if (idx == KP_SPI_REG_CONFIG && cs->conf_cache >= 0)

I like these changes but Greg doesn't.  So don't bother with this one.

>               return cs->conf_cache;
>  
>       val = readq(addr);

The rest of the changes are fine.  Split them into multiple patches and
resend.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to