On Mon, Oct 07, 2019 at 03:29:28PM -0700, Nachammai Karuppiah wrote:
> Remove NULL comparison. Issue found using checkpatch.pl
>
> Signed-off-by: Nachammai Karuppiah <nachukan...@gmail.com>
>
> ---
>
> Changes in V2
> - Remove all NULL comparisons in vc04_services/interface directory.
> ---
> .../interface/vchiq_arm/vchiq_2835_arm.c | 4 ++--
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 28
> +++++++++++-----------
> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 4 ++--
> .../vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +-
> 4 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git
> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> index 8dc730c..7cdb21e 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> @@ -526,11 +526,11 @@ create_pagelist(char __user *buf, size_t count,
> unsigned short type)
> return NULL;
> }
>
> - WARN_ON(g_free_fragments == NULL);
> + WARN_ON(!g_free_fragments);
>
> down(&g_free_fragments_mutex);
> fragments = g_free_fragments;
> - WARN_ON(fragments == NULL);
> + WARN_ON(!fragments);
> g_free_fragments = *(char **) g_free_fragments;
> up(&g_free_fragments_mutex);
> pagelist->type = PAGELIST_READ_WITH_FRAGMENTS +
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index b1595b1..b930148 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -826,8 +826,8 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned
> long arg)
>
> /* Remove all services */
> i = 0;
> - while ((service = next_service_by_instance(instance->state,
> - instance, &i)) != NULL) {
> + while (service = next_service_by_instance(instance->state,
> + instance, &i)) {
As you can see, this added a build warning. Please always be careful
about your patches to not have them do that :(
Please fix up and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
