As Joe Perches suggested [1],
                err = bio_add_page(bio, page, PAGE_SIZE, 0);
-               if (unlikely(err != PAGE_SIZE)) {
+               if (err != PAGE_SIZE) {
                        err = -EFAULT;
                        goto err_out;
                }

The initial assignment to err is odd as it's not
actually an error value -E<FOO> but a int size
from a unsigned int len.

Here the return is either 0 or PAGE_SIZE.

This would be more legible to me as:

                if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) {
                        err = -EFAULT;
                        goto err_out;
                }

[1] 
https://lore.kernel.org/r/74c4784319b40deabfbaea92468f7e3ef44f1c96.ca...@perches.com/
Reported-by: Joe Perches <j...@perches.com>
Signed-off-by: Gao Xiang <gaoxian...@huawei.com>
---
v2: no change, just resend in case of dependency problem;

 fs/erofs/data.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 0f2f1a839372..0983807737fd 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -69,8 +69,7 @@ struct page *__erofs_get_meta_page(struct super_block *sb,
                        goto err_out;
                }
 
-               err = bio_add_page(bio, page, PAGE_SIZE, 0);
-               if (err != PAGE_SIZE) {
+               if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) {
                        err = -EFAULT;
                        goto err_out;
                }
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to