On Tue, Mar 19, 2019 at 05:36:22PM +0100, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
> 
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>

Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

> ---
> 
> Build tested only. buildbot is happy.
> 
>  drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c 
> b/drivers/staging/media/imx/imx7-mipi-csis.c
> index 2ddcc42ab8ff..44569c63e4de 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -1039,8 +1039,7 @@ static int mipi_csis_probe(struct platform_device *pdev)
>  
>  static int mipi_csis_pm_suspend(struct device *dev, bool runtime)
>  {
> -     struct platform_device *pdev = to_platform_device(dev);
> -     struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev);
> +     struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev);
>       struct csi_state *state = mipi_sd_to_csis_state(mipi_sd);
>       int ret = 0;
>  
> @@ -1064,8 +1063,7 @@ static int mipi_csis_pm_suspend(struct device *dev, 
> bool runtime)
>  
>  static int mipi_csis_pm_resume(struct device *dev, bool runtime)
>  {
> -     struct platform_device *pdev = to_platform_device(dev);
> -     struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev);
> +     struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev);
>       struct csi_state *state = mipi_sd_to_csis_state(mipi_sd);
>       int ret = 0;
>  
> -- 
> 2.11.0
> 
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to