On Tue, Mar 05, 2019 at 08:34:50AM +0000, Omer Shpigelman wrote:
> From: Dan Carpenter <dan.carpen...@oracle.com>
> Sent: Tuesday, 5 March 2019 8:40
> > Hello Omer Shpigelman,
> > 
> > The patch 0feaf86d4e69: "habanalabs: add virtual memory and MMU
> > modules" from Feb 16, 2019, leads to the following static checker
> > warning:
> > 
> >     drivers/misc/habanalabs/memory.c:96 alloc_device_memory()
> >     warn: integer overflows '(args->alloc.mem_size + (page_size - 1)) >>
> > page_shift'
> > 
> 
> You are correct, we'll send a fix shortly.
> BTW which static checker did you use? we use Sparse and Smatch and they 
> didn't catch that.

It's not released because it's pretty rubbish.  Checking for integer
overflows is hard.  And then when you find a real integer overflow, it
can can be deliberate and/or harmless.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to