Hi Florian, I love your patch! Yet something to improve:
[auto build test ERROR on net/master] [also build test ERROR on v5.0-rc4 next-20190205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Introduce-ndo_get_port_parent_id/20190205-163356 config: i386-randconfig-b0-02041055 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function 'bnxt_vf_rep_get_port_parent_id': >> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:248:50: error: 'attr' >> undeclared (first use in this function) return bnxt_get_port_parent_id(vf_rep->bp->dev, attr); ^ drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:248:50: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:249:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ vim +/attr +248 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c 239 240 static int bnxt_vf_rep_get_port_parent_id(struct net_device *dev, 241 struct netdev_phys_item_id *ppid) 242 { 243 struct bnxt_vf_rep *vf_rep = netdev_priv(dev); 244 245 /* as only PORT_PARENT_ID is supported currently use common code 246 * between PF and VF-rep for now. 247 */ > 248 return bnxt_get_port_parent_id(vf_rep->bp->dev, attr); 249 } 250 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
